Don't serialize backwardCompatibleMessage field from RepositoryConflictException in V9
#122730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flictException` in V9 This field was deprecated in V8 and removed in elastic#114726. We don't need to serialize it in V9
arteam
added
>non-issue
:Distributed Coordination/Snapshot/Restore
DaveCTurner
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Change LGTM but this can only go into main, to land in 9.1.0, and you've labelled it for 9.0.1. I don't think there's value in backporting the change to the 9.0 branch, see this comment. We just need to remove the @UpdateForV9 markers there.
DaveCTurner
added
v9.1.0
and removed
v9.0.1
auto-backport
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
arteam
added a commit
that referenced
this pull request
Feb 17, 2025
#122730 added checks in 9.1.0 that `backwardCompatibleMessage` won't be serialized
arteam
added a commit
that referenced
this pull request
Feb 17, 2025
* Remove `@UpdateForV9` from `RepositoryConflictException` #122730 added checks in 9.1.0 that `backwardCompatibleMessage` won't be serialized * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was deprecated in V8 and removed in #114726. We don't need to serialize it in V9